From 4a294434c582df1475082cbabe1da5bb4702f989 Mon Sep 17 00:00:00 2001 From: Anderson Queiroz Date: Tue, 8 Feb 2022 12:45:30 +0100 Subject: [PATCH 1/2] add message to register encode/decode debug logs --- filebeat/beater/crawler.go | 2 +- x-pack/filebeat/input/httpjson/encoding.go | 18 +++++++++++++----- 2 files changed, 14 insertions(+), 6 deletions(-) diff --git a/filebeat/beater/crawler.go b/filebeat/beater/crawler.go index 7e5ce969f5fb..f642db760ba4 100644 --- a/filebeat/beater/crawler.go +++ b/filebeat/beater/crawler.go @@ -130,7 +130,7 @@ func (c *crawler) startInput( runner, err := c.inputsFactory.Create(pipeline, config) if err != nil { - return fmt.Errorf("Error while initializing input: %+v", err) + return fmt.Errorf("error while initializing input: %+v", err) } if inputRunner, ok := runner.(*input.Runner); ok { inputRunner.Once = c.once diff --git a/x-pack/filebeat/input/httpjson/encoding.go b/x-pack/filebeat/input/httpjson/encoding.go index 38bc6c2ad3a9..de93c9ca924d 100644 --- a/x-pack/filebeat/input/httpjson/encoding.go +++ b/x-pack/filebeat/input/httpjson/encoding.go @@ -79,15 +79,23 @@ func decode(contentType string, p []byte, dst *response) error { func registerEncoders() { log := logp.L().Named(logName) - log.Debug(registerEncoder("application/json", encodeAsJSON)) - log.Debug(registerEncoder("application/x-www-form-urlencoded", encodeAsForm)) + log.Debugf("registering encoder 'application/json': returned error: %#v", + registerEncoder("application/json", encodeAsJSON)) + + log.Debugf("registering encoder 'application/x-www-form-urlencoded': returned error: %#v", + registerEncoder("application/x-www-form-urlencoded", encodeAsForm)) } func registerDecoders() { log := logp.L().Named(logName) - log.Debug(registerDecoder("application/json", decodeAsJSON)) - log.Debug(registerDecoder("application/x-ndjson", decodeAsNdjson)) - log.Debug(registerDecoder("text/csv", decodeAsCSV)) + log.Debugf("registering decoder 'application/json': returned error: %#v", + registerDecoder("application/json", decodeAsJSON)) + + log.Debugf("registering decoder 'application/x-ndjson': returned error: %#v", + registerDecoder("application/x-ndjson", decodeAsNdjson)) + + log.Debugf("registering decoder 'text/csv': returned error: %#v", + registerDecoder("text/csv", decodeAsCSV)) } func encodeAsJSON(trReq transformable) ([]byte, error) { From 209e21c03a15db995c0c72179bacb94c44221441 Mon Sep 17 00:00:00 2001 From: Anderson Queiroz Date: Fri, 11 Feb 2022 08:17:21 +0100 Subject: [PATCH 2/2] Update crawler.go --- filebeat/beater/crawler.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/filebeat/beater/crawler.go b/filebeat/beater/crawler.go index f642db760ba4..03d67cc65c19 100644 --- a/filebeat/beater/crawler.go +++ b/filebeat/beater/crawler.go @@ -130,7 +130,7 @@ func (c *crawler) startInput( runner, err := c.inputsFactory.Create(pipeline, config) if err != nil { - return fmt.Errorf("error while initializing input: %+v", err) + return fmt.Errorf("error while initializing input: %v", err) } if inputRunner, ok := runner.(*input.Runner); ok { inputRunner.Once = c.once