[enroll] Windows can return err, even when operation is successful

[leehinman]

From CI we have at least one instance of:

[=== ] Waiting For Enroll...  [4s] {"log.level":"info","@timestamp":"2025-02-17T22:04:43.470Z","log.origin":{"function":"github.com/elastic/elastic-agent/internal/pkg/agent/cmd.(*enrollCmd).enrollWithBackoff","file.name":"cmd/enroll_cmd.go","file.line":524},"message":"Starting enrollment to URL: https://079ff92028de13e7d02afc20ee027b5f.fleet.us-west2.gcp.elastic-cloud.com:443/","ecs.version":"1.6.0"}
        Error: failed to fix permissions: The operation completed successfully.

That error is coming from

elastic-agent/internal/pkg/agent/cmd/enroll_cmd.go

Line 287 in 1eefbe0

return errors.New(err, "failed to fix permissions")

So apparently on Windows perms.FixPermissions can return an "Error" of "The operation completed successfully". So we need to handle this.

[pkoutsovasilis]

@michel-laterman since you are the author of this PR could the root reason behind this issue be the fact that we don't check for Errno(0) here https://github.com/elastic/elastic-agent/blob/main/internal/pkg/agent/perms/windows.go#L103?

Related CI failures are here and they are regarding sudo and windows, thus, I expect the the if isAdmin branch to be executed

[michel-laterman]

Yes, this is likely a case that we forgot to test for errors.Is(err, syscall.Errno(0)) for the error that can be returned from

elastic-agent/internal/pkg/agent/perms/windows.go

Lines 102 to 104 in 1eefbe0

	if userSID != nil && groupSID != nil {
	err = takeOwnership(name, userSID, groupSID)
	}

[elasticmachine]

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)