Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[visualize embeddable] Filters notification not displayed for visualize embeddable in Dashboard #193598

Open
nreese opened this issue Sep 20, 2024 · 3 comments
Labels
bug Fixes for quality problems that affect the customer experience regression Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@nreese
Copy link
Contributor

nreese commented Sep 20, 2024

Following #192002, filters notification badge is only displayed for embeddables that partially implement the unified search interface. The code snippet below shows the isApiCompatible check used by the filters notification action. If this check returns false, then the filters notification badge is not displayed for a panel.

https://github.com/elastic/kibana/blob/main/src/plugins/dashboard/public/dashboard_actions/filters_notification_action.tsx#L41

const isApiCompatible = (api: unknown | null): api is FiltersNotificationActionApi =>
  Boolean(
    apiHasUniqueId(api) && apiCanAccessViewMode(api) && apiPublishesPartialUnifiedSearch(api)
  );

The visualize embeddable does not implement unified search interface and provide filters$ or query$. This results in the filters notification badge not getting displayed for the visualize embeddable.

Steps to reproduce

  1. install sample web logs
  2. create aggregation based embeddable with filter
  3. add visualize to dashboard. Filter notification badge should be displayed in the panel heading. Instead, it is missing. In the screen shot below, notice how the saved search panel displays the filter notification badge while the visualize panel does not.
    Image
@nreese nreese added bug Fixes for quality problems that affect the customer experience regression Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Sep 20, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@mbondyra
Copy link
Contributor

Hi @nreese , thank you for identifying the root cause! Would you mind taking this one on? It looks like the bug was introduced with the recent embeddable refactor, and it’s not clear if it falls under the Visualizations team as it is related to Embeddables new architecture. We’re currently tied up with the Lens refactor, so your help here would be incredibly appreciated! 🙏

@mbondyra mbondyra added the Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas label Sep 23, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Fixes for quality problems that affect the customer experience regression Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

3 participants