[Cloud Posture] Remove k8s instructions for cspm policies #146843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security Posture) |
kfirpeled
added
release_note:skip
JordanSh
approved these changes
Dec 4, 2022
botelastic
bot
added
the
Team:Fleet
|
Pinging @elastic/fleet (Team:Fleet) |
JordanSh
reviewed
Dec 4, 2022
| @@ -66,4 +70,14 @@ export function useIsK8sPolicy(agentPolicy?: AgentPolicy) { | |||
| return { isK8s }; | |||
| } | |||
|
|
|||
| const isK8sPackage = (pkg: PackagePolicy) => K8S_PACKAGES.has(pkg.package?.name as string); | |||
There was a problem hiding this comment.
this is a bit problematic since pkg.package? can return undefined and will throw when used in .has().
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Async chunks
Page load bundle
Unknown metric groupsAPI count
ESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When installing CSPM the kubernetes deployment is not relevant and shouldn't be visible.
This PR is fixing that
How to test it
In order to install CSPM integration you use cloud_security_posture 1.1.0 which is recently available elastic/integrations#4752