Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Consider improving Logstash configs in the docs/static/filebeat_modules/*/*.conf #8527

Open
guyboertje opened this issue Oct 25, 2017 · 0 comments
Labels
good first issue hacktoberfest "Everyone is welcome, Quantity is fun, quality is key, Short term actions, long term impact" modules

Comments

@guyboertje
Copy link
Contributor

guyboertje commented Oct 25, 2017

These configs are part of the "adding Logstash to filebeat modules getting started experience" and therefore its very likely the first time a user will see a LS config.

For the best experience we should add a fair few comments to better inform what is going on. The user sees the nested field reference for the first time and there is a try three grok pattern scheme with two mutate renames that work only if earlier grok patterns fail that could be explained better.
Also, we should add grok and date parse failure handling.

Optionally, we could add anchors to Grok patterns.

@jsvd jsvd added hacktoberfest "Everyone is welcome, Quantity is fun, quality is key, Short term actions, long term impact" and removed hacktoberfest "Everyone is welcome, Quantity is fun, quality is key, Short term actions, long term impact" labels Oct 1, 2018
@danhermann danhermann added the hacktoberfest "Everyone is welcome, Quantity is fun, quality is key, Short term actions, long term impact" label Oct 1, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
good first issue hacktoberfest "Everyone is welcome, Quantity is fun, quality is key, Short term actions, long term impact" modules
Projects
None yet
Development

No branches or pull requests

3 participants