Build multi-arch Docker image #1878
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running the docker image with a mounted `/rally/.rally` directory that already contains the configuration file didn't work. So I had to change how we parse the logging config and rally.ini files. Now we dealy the parsing of the environment variables to read time, to make running from docker and outside of docker compatible with each other.
I'd been installing `esrally` to the wrong location, now it's correctly in venv/bin
and possibly break users' workflows.
pquentin
added
enhancement
|
Hah, I've also been working on #1873 That one tests both architectures, and uses buildkite runners of each architecture in parallel. Followed by a manifest command to merge them I also wanted to have a |
|
Excellent! Closing in favor of #1873. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request builds on top of #187. It adds multi-arch builds as done in Eland nearly one year ago: elastic/eland#615. The main difference is that in Rally we test the image before pushing it. However, this workflow is not supported for multi-arch images: docker/buildx#59. As a workaround, we build a linux/amd64 image first, test it, and then build and push the actual multi-arch image with linux/amd64 and linux/arm64. While it is named linux/arm64, it's supported natively on Apple silicon hardware, such as M1/M2/M3 MacBooks.
To review this, the only relevant commit is 515ce21. I believe this should only be merged after #1871, because it's a different concern, and may need to be reverted independently.