Creating HFS+ DMG using hdiutil on Intel Mac fails on OS X 15.2

[fwdillema]

          This is the only process.arch-specific logic that happens when creating the initial dmg

electron-builder/packages/dmg-builder/src/dmg.ts

Lines 204 to 213 in 59767b0

	let filesystem = ["HFS+", "-fsargs", "-c c=64,a=16,e=16"]
	if (process.arch === "arm64") {
	// Apple Silicon `hdiutil` dropped support for HFS+, so we force the latest type
	// https://github.com/electron-userland/electron-builder/issues/4606
	filesystem = ["APFS"]
	log.warn(null, "Detected arm64 process, HFS+ is unavailable. Creating dmg with APFS - supports Mac OSX 10.12+")
	}
	imageArgs.push("-fs", ...filesystem)
	imageArgs.push(tempDmg)
	await hdiUtil(imageArgs)

Re: The volume name, we use sanitize-filename under the hood.

electron-builder/packages/dmg-builder/src/dmg.ts

Line 45 in 59767b0

const volumeName = sanitizeFileName(this.computeVolumeName(arch, this.options.title))

electron-builder/packages/app-builder-lib/src/util/filename.ts

Lines 5 to 8 in 59767b0

	export function sanitizeFileName(s: string, normalizeNfd = false): string {
	const sanitized = _sanitizeFileName(s)
	return normalizeNfd ? sanitized.normalize("NFD") : sanitized
	}

Originally posted by @mmaietta in #8415 (comment)

[fwdillema]

Creating the DMG with APFS on Intel Macs does work on OS X 15.2 (AFAIK HFS+ still worked on OS X 15.1). I guess the arch check should be extended with an OS version check to make this correct for all macs.

[mmaietta]

I wonder if Apple finally sunset support for building HFS+ in the 15.2.

With electron-builder v26 major semver bump, it may be best to drop the arch-specific logic entirely and move to APFS entirely. The warning logged has been present for years.