Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Python 3 has a different syntax for imports #4

Open
jvazquez opened this issue Aug 1, 2016 · 0 comments
Open

Python 3 has a different syntax for imports #4

jvazquez opened this issue Aug 1, 2016 · 0 comments

Comments

@jvazquez
Copy link

jvazquez commented Aug 1, 2016

I'm testing your code using python 3.5.1

I forked your project, but noticed that you have an open pull request that fixes this situation

#3

`
Python 3.5.1 (default, May 1 2016, 12:06:57)
[GCC 5.2.1 20151010] on linux
Type "help", "copyright", "credits" or "license" for more information.

from awses.connection import AWSConnection
Traceback (most recent call last):
File "", line 1, in
File "/home/jvazquez/.pyenv/versions/msaas_profile/lib/python3.5/site-packages/awses/connection.py", line 2, in
from signer import ESConnection
ImportError: No module named 'signer'
`

Would it be possible to accept that pr ?

Though, one change that it could be applied on the PR3 is the import of urlparse

is

try:
    from urllib.parse import urlparse
except ImportError:
   from urlparse import urlparse

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant