Skip to content
This repository was archived by the owner on Dec 10, 2018. It is now read-only.

New thrift parser using ply #36

Closed
wants to merge 22 commits into from
Closed

New thrift parser using ply #36

wants to merge 22 commits into from

Conversation

hit9
Copy link
Contributor

@hit9 hit9 commented Sep 3, 2014

Main changes:

  1. thrift/parser.py => thrift/parser/
  2. removed cache.
  3. tests cases for new parser ( tests/test_parser.py, tests/parser-cases/)
  4. setup.py version: use literal but not version imported from thriftpy.

@hit9
Copy link
Contributor Author

hit9 commented Sep 3, 2014

关于改动4, 与该feature无关,可以合掉后再修改。。但是我觉得写死为string没什么不好的。 像node中npm的package是json格式的,整个都是死的,没有从项目文件中导入的信息。

@lxyu lxyu closed this in 2b53ce4 Sep 4, 2014
@lxyu
Copy link
Contributor

lxyu commented Sep 4, 2014

Merged in 2b53ce4

Thanks!

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants