Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Olm sessions imported from legacy crypto will always be used in preference to newer olm sessions #7727

Closed
richvdh opened this issue Dec 22, 2023 · 1 comment
Closed

Olm sessions imported from legacy crypto will always be used in preference to newer olm sessions #7727

richvdh opened this issue Dec 22, 2023 · 1 comment

Comments

@richvdh
Copy link
Member

richvdh commented Dec 22, 2023

Background: If an Olm session "wedges", we will attempt to work around it by starting a new session. Later, when either side wants to send another olm message, it will use the most recent Olm session -- ie, the new session.

However: when sessions are imported from legacy crypto, their "creation_time" and "last_used_time" are both set 50000 years in the future. (They are set in milliseconds rather than seconds. See also matrix-org/matrix-rust-sdk#2974, matrix-org/matrix-rust-sdk#2973.) That means that the imported session will always be used in preference to any newer sessions.
@richvdh richvdh mentioned this issue Dec 22, 2023
Closed
@richvdh
Copy link
Member Author

richvdh commented Dec 22, 2023

Turns out iOS does this right, actually.

@richvdh richvdh closed this as completed Dec 22, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
Issue triage
Status: Closed
Milestone
No milestone
Development

No branches or pull requests
1 participant
@richvdh