Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Consider making timeout configurable when reading a file body #16912

Open
dkasak opened this issue Feb 13, 2024 · 0 comments
Open

Consider making timeout configurable when reading a file body #16912

dkasak opened this issue Feb 13, 2024 · 0 comments
Labels
A-URL-Preview O-Uncommon T-Enhancement

Comments

@dkasak
Copy link
Member

dkasak commented Feb 13, 2024

In matrix-org/synapse#11784, a timeout was introduced to the HTTP client when downloading a file body, to patch CVE-2022-41952. The timeout was hardcoded to 30s which could be overly long in some settings.

It could make sense to expose this as a setting so that the homeserver admin can configure it.
@dkasak dkasak changed the title Consider making timeout when reading a file body configurable Consider making timeout configurable when reading a file body configurable Feb 13, 2024
@anoadragon453 anoadragon453 changed the title Consider making timeout configurable when reading a file body configurable Consider making timeout configurable when reading a file body Jun 7, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
A-URL-Preview O-Uncommon T-Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dkasak @anoadragon453