Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Make the input flat #277

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Make the input flat #277

wants to merge 4 commits into from

Conversation

alainm23
Copy link

@alainm23 alainm23 commented Feb 6, 2025

Fixed #275

image

@alainm23 alainm23 changed the title Entry Flat Make the input flat Feb 6, 2025
@alainm23 alainm23 requested a review from a team February 6, 2025 21:39
@ryonakano

This comment was marked as resolved.

# to view
@alainm23

This comment was marked as resolved.

# to view
ryonakano
ryonakano reviewed Feb 12, 2025
View reviewed changes
Copy link
Member

@ryonakano ryonakano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the replace_text handler no longer working with this branch.

This branch:

2025-02-12 13 14 43 のスクリーンショット

Latest origin/main (479cc48):
2025-02-12 13 16 29 のスクリーンショット

@ryonakano
Copy link
Member

I see the following critical warnings on the terminal:

(io.elementary.calculator:8416): GLib-GObject-CRITICAL **: 13:11:24.552: invalid (NULL) pointer instance

(io.elementary.calculator:8416): GLib-GObject-CRITICAL **: 13:11:24.552: g_signal_connect_object: assertion 'G_TYPE_CHECK_INSTANCE (instance)' failed

And these warnings are out at src/MainWindow.vala:474 according to gdb:

user@elementary-8:~/work/calculator$ G_DEBUG=fatal-criticals gdb io.elementary.calculator 
:

(io.elementary.calculator:8889): GLib-GObject-CRITICAL **: 13:14:54.928: invalid (NULL) pointer instance

Thread 1 "io.elementary.c" received signal SIGTRAP, Trace/breakpoint trap.
0x00007ffff7ec56a1 in g_logv () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
(gdb) bt
#0  0x00007ffff7ec56a1 in g_logv () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#1  0x00007ffff7ec5953 in g_log () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#2  0x00007ffff7e3d5aa in g_type_check_instance () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
#3  0x00007ffff7e251a9 in g_signal_connect_object () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
#4  0x00005555555677fb in pantheon_calculator_main_window_constructor (type=Python Exception <class 'gdb.error'>: No type named TypeNode.
, n_construct_properties=5, construct_properties=0x7fffffffcf60) at ../src/MainWindow.vala:474

@alainm23
Copy link
Author

Sorry, I didn't know about that feature. I went back to using Gtk.Entry and applied CSS instead.

@alainm23 alainm23 requested a review from ryonakano February 13, 2025 00:18
ryonakano
ryonakano reviewed Feb 14, 2025
View reviewed changes
ryonakano
ryonakano reviewed Feb 14, 2025
View reviewed changes
data/Application.css
@@ -0,0 +1,4 @@
entry.flat {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From #275 (comment):

That's true, but Gtk.Entry has other classes that still show the focus or active border when the input is focused.

This may be due to the following lines? Isn't there any way to just remove the focused style class and avoid re-implementing the entry.flat class here? 🤔

https://github.com/elementary/stylesheet/blob/b92637c9608a2455060b89fe17c8be98ffaaf355/src/gtk-4.0/widgets/_entries.scss#L21-L23

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ryonakano ryonakano ryonakano left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make the input flat
2 participants
@alainm23 @ryonakano