Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Ownership pool can not start Sojourn pool #106

Closed
fishcakez opened this issue Nov 27, 2017 · 4 comments
Closed

Ownership pool can not start Sojourn pool #106

fishcakez opened this issue Nov 27, 2017 · 4 comments
Milestone

Comments

@fishcakez
Copy link
Member

The Ownership pool starts its internal pool via the Watcher, and Sojourn starts its internal pool via the Watcher. The Watcher blocks when starting an internal pool so can't receive the request from Sojourn to start its internal pool as it blocking starting the Sojourn pool itself (Ownership's internal pool).

@fishcakez fishcakez added this to the v1.2 milestone Nov 27, 2017
@josevalim
Copy link
Member

FWIW, I am completely fine with saying we only work with poolboy if fixing it is going to be a big hassle.

@fishcakez
Copy link
Member Author

I am happy to force poolboy too. This isn't an issue for Ecto because poolboy will always be there.

@michalmuskala
Copy link
Member

michalmuskala commented Nov 27, 2017

👍 for ownership pool working only with poolboy. Should we remove the ability to specify the "inner" pool for ownership pool altogether?

@michalmuskala
Copy link
Member

michalmuskala commented May 19, 2018

I will close the issue given we'll be moving away from poolboy and sojurn in 2.0. This is tracked in #108

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants