Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Broken syntax after ticks ``` within @moduledoc string #444

Open
macabl opened this issue Oct 11, 2019 · 6 comments
Open

Broken syntax after ticks ``` within @moduledoc string #444

macabl opened this issue Oct 11, 2019 · 6 comments

Comments

@macabl
Copy link

macabl commented Oct 11, 2019

Hi,

I am trying to edit this file, but becomes a bit difficult due to broken syntax highlight:
https://github.com/bleacherreport/plug_logger_json/blob/master/lib/plug/logger_json.ex

sel-2019-10-11--19:16:16

@jsmestad
Copy link
Contributor

Are backticks valid like that in moduledoc? I know docs can be markdown, but I was unsure if that meant also codeblocks and code highlighting with like ```json

@axelson
Copy link
Contributor

axelson commented Jun 17, 2020

Is this still an issue? I'm not able to reproduce it. ```json should be valid within a heredoc ("""), although highlighting the content as JSON is not supported.

@victorolinasc
Copy link
Contributor

I believe this is a side effect of the many changes that went into Emacs 27 about regexes. Currently, elixir-mode.el is almost completely based on regexes (as most major-modes are).

I had similar issues while surfing the master branch of Emacs. I am currently on Emacs 28 on feat/native-comp branch and also can't reproduce the results.

We had other issues about regexes mentioned here and some were even discussed on emacs-devel. I think we should wait for a reply from who posted the issue but I guess it was not anything in the code of elixir-mode.

@axelson
Copy link
Contributor

axelson commented Jun 17, 2020

Yeah, I was having issues with """ on Emacs 27, but for me that went away a few weeks ago (and I'm still on Emacs 27).

@konstantinzolotarev
Copy link

I suppose this is issue in JSON itself (missing comma after fronts#index).

@victorolinasc
Copy link
Contributor

@macabl can you confirm the issue is gone? If not, can you detail your setup a little bit more? I think there are people using modes for highlighting documentations that might be the cause here too.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants