Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Should vtkio::Error implement std::error::Error? #5

Closed
Andlon opened this issue Aug 7, 2019 · 3 comments
Closed

Should vtkio::Error implement std::error::Error? #5

Andlon opened this issue Aug 7, 2019 · 3 comments

Comments

@Andlon
Copy link
Collaborator

Andlon commented Aug 7, 2019

See title. I think this would make sense and would allow for more rapid prototyping with e.g. functions returning Box<std::error::Error>.

I would happily submit a PR (once time permits...) if you agree that this could be useful.

@elrnv
Copy link
Owner

elrnv commented Aug 8, 2019

Yes this makes sense to me. I'd be happy to accept a PR for that.
In general, I'm open to contributions that improve compatibility with the rest of the ecosystem.

@elrnv
Copy link
Owner

elrnv commented Sep 10, 2019

This was done in 61525fe and published in v0.2.4.
It would also be nice to extend this to writer::Error but I moved that into a separate issue since it's not as important.

Closing this for now, but happy to accept improvements/adjustments.

@elrnv elrnv closed this as completed Sep 10, 2019
@Andlon
Copy link
Collaborator Author

Andlon commented Sep 17, 2019

Thanks, that's great! I haven't been actively using VTK lately (but I will soon enough), which is why I never got around to contributing the feature myself.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants