Skip to content

run-loop information needs to be updated #187

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
4 tasks
MelSumner opened this issue Oct 5, 2018 · 3 comments
Closed
4 tasks

run-loop information needs to be updated #187

MelSumner opened this issue Oct 5, 2018 · 3 comments
Labels
has a PR

Comments

@MelSumner
Copy link
Member

As per https://github.com/rwjblue/rfcs/blob/embrace-the-autorun/text/0000-remove-autorun-assertion.md the guide content needs to be updated to reflect the current reality of the run-loop.

  • review the guides for mention of run-wrapping, and remove them.
  • update the run-loop guide:
    • change the verbiage that mentions the reasoning for the autorun assertion
    • remove instructions to Ember.run wrap things
@MelSumner MelSumner added help wanted Extra attention is needed Hacktoberfest Issue counts towards Hacktoberfest labels Oct 5, 2018
@sivakumar-kailasam
Copy link
Member

@gokatz this might interest you 🙂

@gokatz
Copy link
Contributor

gokatz commented Oct 5, 2018

Yes, it is 😸
Will revamp those sections

@gokatz gokatz mentioned this issue Oct 6, 2018
Merged
@jenweber jenweber added needs contributor response has a PR and removed help wanted Extra attention is needed Hacktoberfest Issue counts towards Hacktoberfest needs contributor response labels Oct 9, 2018
@locks
Copy link
Contributor

locks commented Mar 1, 2019

PR is merged!

@locks locks closed this as completed Mar 1, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
has a PR
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@locks @sivakumar-kailasam @MelSumner @gokatz @jenweber