Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Empty mixins break component selector #752

Closed
XuluWarrior opened this issue Feb 23, 2018 · 0 comments
Closed

Empty mixins break component selector #752

XuluWarrior opened this issue Feb 23, 2018 · 0 comments
Labels

Comments

@XuluWarrior
Copy link
Contributor

If an app includes an empty mixin, selecting a component using either the magnifying glass and clicking on the component name or clicking the View / Component in the View Tree causes a call stack in ember-inspector in propertiesForMixin(mixin) where it expects all mixins to have a mixins array.

Version 0.6.2 of ember-component-css includes such an empty mixin and so breaks ember-inspector for apps that use it.

You can see the behaviour when running https://github.com/XuluWarrior/ember-component-css-test

I have already raised webark/ember-component-css#274 but it seems that ember-inspector should be robust enough to deal with empty mixins.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants