Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Nested component blocks in precompiled templates don't work #3772

Closed
tim-evans opened this issue Nov 20, 2013 · 4 comments
Closed

Nested component blocks in precompiled templates don't work #3772

tim-evans opened this issue Nov 20, 2013 · 4 comments

Comments

@tim-evans
Copy link
Contributor

I'm using ember-rails and have encountered a bug where the patch code for the Handlebars compiler isn't run when precompiling the templates (patch here: https://github.com/emberjs/ember.js/blob/master/packages/ember-handlebars-compiler/lib/main.js#L177-L212). This was introduced in commit 34ae167.

@machty
Copy link
Contributor

machty commented Nov 20, 2013

This is almost certainly because you're precompiling templates with an older version of the ember-template-compiler.

If you update ember-source to something like http://rubygems.org/gems/ember-source/versions/1.2.0.beta.4 this should go away (and make sure to clear your assets cache to make sure everything's getting fully re-precompiled)

Close if this ends up being the case.

@machty
Copy link
Contributor

machty commented Nov 20, 2013

#3729 would go a long way to giving people more information when this happens

@rwjblue
Copy link
Member

rwjblue commented Nov 20, 2013

Agreed. #3729 likely needs to happen before 1.2.0 gets released.

@wagenet
Copy link
Member

wagenet commented Nov 26, 2013

Closing since #3729 was merged and is in 1.2. If there are still issues, let us know.

@wagenet wagenet closed this as completed Nov 26, 2013
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants