Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Don't use text-encoding package (certainly not in browsers) #34

Closed
sachaw opened this issue Feb 6, 2022 · 3 comments · Fixed by #35
Closed

Don't use text-encoding package (certainly not in browsers) #34

sachaw opened this issue Feb 6, 2022 · 3 comments · Fixed by #35

Comments

@sachaw
Copy link
Contributor

sachaw commented Feb 6, 2022 •
edited
Loading

I love this package, however I am using this in a very space constrained application, and the inclusion of the text-encoding package adds 615kb to my uncompressed bundle size (single largest dep by far). It's also deprecated.

I'd be happy to help get this working.
@oori
Copy link
Collaborator

oori commented Feb 6, 2022

@splix Why was TextEncoder added?
e386fb3

@splix
Copy link
Member

splix commented Feb 6, 2022

hm, I think it was part of something different, but ended up committing it. I don't think it's used.

@sachaw can you try to remove the dependency and see if that works for you? If yes, I'd appreciate a pull request.

@sachaw sachaw mentioned this issue Feb 6, 2022
Merged
@splix splix closed this as completed in #35 Feb 8, 2022
@splix
Copy link
Member

splix commented Feb 8, 2022

@sachaw published to NPM as v0.5.2

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove text-encoding polyfill sachaw/hashicon
3 participants
@splix @oori @sachaw