Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Code Cleanup / Tests #41

Open
2 tasks
rossPatton opened this issue Jul 30, 2020 · 3 comments
Open
2 tasks

Code Cleanup / Tests #41

rossPatton opened this issue Jul 30, 2020 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers no-issue-activity

Comments

@rossPatton
Copy link
Member

Not tied to either milestone.

A post-release cleanup pass wouldn't hurt. Particularly, we use Typescript, and haven't been doing a great job there keeping our types accurate and up-to-date.

The Expo framework also provides us with Jest testing built-in, but we haven't yet made use of it. We should probably write some unit tests. Given how small the app is, shouldn't be too hard to get good coverage.

  • All types used should be useful and accurate. No 'any' used anywhere
  • Achieve at least 80% code coverage with Jest unit tests
@rossPatton rossPatton added enhancement New feature or request good first issue Good for newcomers labels Jul 30, 2020
@faahmad
Copy link

faahmad commented Sep 22, 2020

I'd like to help with this. Do we have acceptance criteria?

@rossPatton
Copy link
Member Author

rossPatton commented Sep 24, 2020

Unfortunately not at the moment, what would you be looking for? If there starts to be more interest in this project, that's something we could certainly codify

I think, at this point, I'd take anything that gets our test coverage % up

@github-actions
Copy link

Stale issue message

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request good first issue Good for newcomers no-issue-activity
Projects
None yet
Development

No branches or pull requests

2 participants