Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Plot always zooms out when changing data aspect #2077

Closed
saecki opened this issue Sep 22, 2022 · 1 comment · Fixed by #2087
Closed

Plot always zooms out when changing data aspect #2077

saecki opened this issue Sep 22, 2022 · 1 comment · Fixed by #2087
Labels
bug Something is broken

Comments

@saecki
Copy link
Contributor

saecki commented Sep 22, 2022

This is a regression, I mentioned the original bug in this issue: #1174
and it was fixed in the linked PR: #1184

Seems like this PR broke it #1865 in plot/mod.rs line 723-728.
If no axis is linked it will always expand.

transform.set_aspect_by_expanding(data_aspect as f64);

In the else case change_x should probably be defaulted to false as before.

@saecki saecki added the bug Something is broken label Sep 22, 2022
@saecki
Copy link
Contributor Author

saecki commented Sep 22, 2022

I don't know how that will impact the issue with the auto bounds though

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something is broken
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant