Customize Plot label and cursor texts #1235
Conversation
egui/src/widgets/plot/mod.rs
Outdated
| pub fn with_precision(precision: usize) -> Self { | ||
| Self { | ||
| function: Box::new(move |value| { | ||
| format!("x: {:.p$}\ny: {:.p$}", value.x, value.y, p = precision) | ||
| }), | ||
| } | ||
| } |
There was a problem hiding this comment.
Here (and in other places) it would be great to have a function to format with a fixed number of significant digits. Does egui happen to already have this functionality somewhere?
egui/src/widgets/plot/mod.rs
Outdated
| emath::round_to_decimals(value.x, precision).to_string(), | ||
| emath::round_to_decimals(value.y, precision).to_string(), |
There was a problem hiding this comment.
| emath::round_to_decimals(value.x, precision).to_string(), | |
| emath::round_to_decimals(value.y, precision).to_string(), | |
| format!("{:.*}", decimal_places, value.x), | |
| format!("{:.*}", decimal_places, value.y), |
Look at emath::round_to_decimals and you see why the old code was weird :)
There was a problem hiding this comment.
Haha I see, then we should also replace it down here right?
https://github.com/emilk/egui/blob/master/egui/src/widgets/plot/mod.rs#L952
There was a problem hiding this comment.
Ah, no there it's different.
Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
| type AxisFormatterFn = dyn Fn(f64) -> String; | ||
| type LabelFormatterFn = dyn Fn(&str, &Value) -> String; | ||
| type LabelFormatter = Option<Box<LabelFormatterFn>>; | ||
| type AxisFormatterFn = dyn Fn(f64, &RangeInclusive<f64>) -> String; |
There was a problem hiding this comment.
In a future PR we could change these to return WidgetText instead, allowing users to color the output.
| @@ -753,7 +762,6 @@ impl super::View for PlotDemo { | |||
| egui::reset_button(ui, self); | |||
| ui.collapsing("Instructions", |ui| { | |||
| ui.label("Pan by dragging, or scroll (+ shift = horizontal)."); | |||
| ui.label("Box zooming: Right click to zoom in and zoom out using a selection."); | |||
There was a problem hiding this comment.
Absolutely, good catch. Added the line again in 8cc5363.
emilk
changed the title
Closes #1234
This was developed internally at embotech AG. We use egui extensively and would like to contribute changes that could benefit the open-source community.