Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add IME support for native #2046

Merged
merged 5 commits into from
Sep 15, 2022
Merged

Add IME support for native #2046

merged 5 commits into from
Sep 15, 2022

Conversation

SheldonNico
Copy link
Contributor

Add IME support to native. Tested on Windows 10, MacOS 10.15.3 and chrome. Sorry for my poor English.

Snipaste_2022-09-15_20-13-53

Closes #248.

@SheldonNico
Copy link
Contributor Author

on Windows and chrome

190089937-437f7ae6-82a4-4568-948b-a5b311bcf862

Copy link
Owner

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I think input_method_editor_started is unused afaict?

@SheldonNico
Copy link
Contributor Author

Both input_method_editor_started and cranky warnings fixed.

@emilk emilk merged commit 0605bcf into emilk:master Sep 15, 2022
@emilk
Copy link
Owner

emilk commented Sep 15, 2022

Awesome, thank you!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IME Support
2 participants