Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove panic on plot grid #3058

Closed
wants to merge 0 commits into from
Closed

Remove panic on plot grid #3058

wants to merge 0 commits into from

Conversation

nrot
Copy link

@nrot nrot commented Jun 6, 2023

Close issue.

Comment on lines 1653 to 1654
if step_size.abs() == 0.0 {
trace!("To small step_size");
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if step_size.abs() == 0.0 {
trace!("To small step_size");
if step_size == 0.0 {
log::trace!("Ignoring step_size of zero");

… though can we still get a panic when step_size is very small, or NaN? What was the actual panic? Can we fix it at the source instead of adding a guard like this?

@nrot
Copy link
Author

nrot commented Oct 1, 2023

Panic this extend. When step_size to small last - first = very big. And then allocated more memory than have system and this is panic in extend.

@emilk emilk marked this pull request as draft January 7, 2024 15:36
@nrot nrot closed this Mar 1, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants