Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

More plot items #471

Merged
merged 4 commits into from
Jun 24, 2021
Merged

More plot items #471

merged 4 commits into from
Jun 24, 2021

Conversation

EmbersArc
Copy link
Contributor

Closes #468. See the issue for the changes.

This got a bit out of hand, sorry about that. I'll have to break it up a bit next, I didn't want to do that in this PR to keep the diff relatively manageable.

@niladic Maybe you want to have a look as well, this changed a couple of things about plot items.

new_items.mp4

* Arrows, also called "Quiver plots" in matplotlib etc.
* Convex polygons
* Text
* Images

Other changes:

* Make HLine/VLine into PlotItems as well.
* Add a "fill" property to Line so that we can fill/shade the area between a line and a horizontal reference line.
* Add stems to Points, which are lines between the points and a horizontal reference line.
* Allow using .. when specifying ranges for values generated by explicit callback functions, as an alias for f64::NEG_INFINITY..f64::INFINITY
* Allow using ranges with exclusive end bounds for values generated by parametric callback functions to generate values where the first and last value are not the same.
@niladic
Copy link
Contributor

niladic commented Jun 10, 2021

Thanks for the heads up @EmbersArc this is impressive! I checked your previous work on your repo before beginning, so what I am working on is compatible. I actually did the same as you with the get_bounds method, I had to rework the series method that you renamed values, but it should be an easy rebase. I will try to push something this week.

@EmbersArc EmbersArc mentioned this pull request Jun 12, 2021
Copy link
Owner

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very impressive, good job!

@emilk emilk merged commit 147e7a4 into emilk:master Jun 24, 2021
@EmbersArc EmbersArc deleted the more-plot-items branch June 25, 2021 21:34
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more plot items
3 participants