Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Maybe the thread pool should no longer be used for reading and writing files? #819

Closed
abersheeran opened this issue Feb 6, 2020 · 1 comment · Fixed by #933
Closed

Maybe the thread pool should no longer be used for reading and writing files? #819

abersheeran opened this issue Feb 6, 2020 · 1 comment · Fixed by #933

Comments

@abersheeran
Copy link
Member

abersheeran commented Feb 6, 2020 •
edited
Loading

I read performance check in mosquito/aiofile#18. Compared to synchronization overhead, it seems that the overhead of the thread pool is greater, maybe we need some performance tests.

And I noticed that aiofiles has not responded to any questions or requests from the community for ten months, which is dangerous. If you insist on reading and writing files asynchronously, maybe starlette should be switched to aiofile?

If there is any need to modify this, I will be happy to do it.
@sm-Fifteen sm-Fifteen mentioned this issue Feb 24, 2020
Merged
@abersheeran
Copy link
Member Author

Tinche/aiofiles#47
Someone has done a performance test here, maybe small file reading and writing should really give up using the thread pool?

@abersheeran abersheeran mentioned this issue May 6, 2020
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Thread pool is no longer used for files in memory
1 participant
@abersheeran