Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add i3 native support + deprecate --wrapper #143

Closed
meator opened this issue Sep 1, 2023 · 1 comment
Closed

Add i3 native support + deprecate --wrapper #143

meator opened this issue Sep 1, 2023 · 1 comment
Assignees
Milestone

Comments

@meator
Copy link
Collaborator

meator commented Sep 1, 2023

As far as I know the only use of --wrapper is to do i3 exec. Therefore this generic feature has only one use and it's failing at it (this is further described in #132).

I propose adding direct support for i3 through i3 IPC. This feature would be fully optional, I myself don't use i3 so j4dd won't depend on it.

I will look up if any other window manager has similar mechanism which would warrant having --wrapper. If not, it will be deprecated in release 3.0 (it will work but it will emit a warning to stderr). It would be removed in a future version then.

Even if the --wrapper option would stay, adding i3 support would still be beneficial. It would mean tighter support for i3, faster execution of programs and more. j4-dmenu-desktop is based on i3-dmenu-desktop so having i3 support would "pay homage to its ancestors". If --wrapper won't be deprecated, a warning shall be issued if j4dd is executed with --wrapper i3\ exec. The warning would direct the user to the new i3 integration.

@meator meator added this to the r3.0 milestone Sep 1, 2023
@meator meator self-assigned this Sep 1, 2023
@meator meator closed this as completed in e8e98c7 Mar 5, 2024
@meator
Copy link
Collaborator Author

meator commented May 15, 2024

--wrapper will not be deprecated in r3.0 release.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant