Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Feature: Ability to drop sitename in title for individual pages #38

Open
rolfrb opened this issue Nov 20, 2018 · 2 comments
Open

Feature: Ability to drop sitename in title for individual pages #38

rolfrb opened this issue Nov 20, 2018 · 2 comments

Comments

@rolfrb
Copy link

rolfrb commented Nov 20, 2018

It's very convenient to have " - sitename" appended to all page titles. But for some pages, you either have to work your way around this or get title that looks weird, like "Feature - only in Company - company" like "New Carname Modelname - Carname". So it would be very nice to have the ability to turn this off on a per page basis (similar to how you can deactivate it for the front page today).

@rolfrb rolfrb changed the title Don Feature: Ability to drop sitename in title for individual pages Nov 20, 2018
@rolfrb
Copy link
Author

rolfrb commented Jan 9, 2019

I have an idea about how I could solve this, and think it would be a fun challenge, @Bellfalasch

It would be an simple fix. The downside is that the UI option to deactivate the site name on a page would show even if showing sitename is already deactivated sitewide. So it would show, even if it doesn't do anything.

Let me know if you

a. don't want this feature to in your app or
b. don't like this particular solution

@Bellfalasch
Copy link
Contributor

Hi, this is not a bad idea but needs some thinking to not clutter the form with even more options. I'm very tempted to break things, as the app initially was built way before we had cool stuff like option sets and x-data, both cool things that could solve all these extra quirks. For instance, today we have in 6.15 a gray box saying "SEO" with a + and you click it to add custom SEO properties, this could have an option (checkbox) for "Advanced settings" with all these things you mention and more, hidden by default. But introducing this would most likely break the backward compatibility for the app, so it would be best to do that when also upgrading the app for 7.0 when it releases. That's why there is currently no action on this task, it will be started on after 7.0 releases.

So yeah, I like the idea!

@enonic enonic deleted a comment from rolfrb Jan 10, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

2 participants