Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Title is required in head and can cause issues if its missing #70

Open
poi33 opened this issue Sep 22, 2021 · 0 comments
Open

Title is required in head and can cause issues if its missing #70

poi33 opened this issue Sep 22, 2021 · 0 comments

Comments

@poi33
Copy link
Contributor

poi33 commented Sep 22, 2021

If the metafields request processor gets a body without title in the head it will replace the first other title it finds anywhere.

If two titles are present in the head it will replace the first one only.
If no titles are present in the head it will replace the first other title it finds. (svg can use title, should use, its good accessiblity)

Related to #63

The difficult part of this is to get a reliable dom manipulation, but needs to be super fast.
We cant add time consuming operations on every single page load.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant