SqlAlchemyDB: get_results_from_node() returns all nodes and not just based on a label

[galwiner]

When SqlAlchemyDB.get_results_from_node('label") is used all results in the db are returned and not just those specified by the label.

Steps to reproduce:

Checkout complex-db branch
run test_fetch_2d_array test

[urig]

@galwiner I've reproduced the behavior in the test but I don't quite understand what the expected behavior is. Perhaps you, @qguyk and I can sync online for this?

[urig]

Following our online discussion today it's realized that this is a bug in get_nodes_id_by_label(). It returns a list of Node id properties but the unique identifier for Nodes actually the combination of its id and experiment_id together.

A quick fix would be to make get_results_from_node() return tuples of node id and experiment_id and re-integrate into any locations calling it.

A more thorough solution is proposed in discussion #145

[galwiner]

Hey @urig, did you make progress on this?

[urig]

Hi Gal. No I haven't. Would love to go for the more thorough solution seeing as we're pre-1.0. Should I?

[urig]

Hi @galwiner. #203 resolves this issue and has been merged to main. Can we close it?