Skip to content

Deal with serde_bytes module #7

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
fjarri opened this issue Oct 12, 2024 · 2 comments · Fixed by #29
Closed

Deal with serde_bytes module #7

fjarri opened this issue Oct 12, 2024 · 2 comments · Fixed by #29
Labels
code quality Making things simpler
Milestone

Comments

@fjarri
Copy link
Member

fjarri commented Oct 12, 2024

For now it's just a fix to handle Box<[u8]> correctly in serialized messages. The problem is:

  • it doesn't support other possible byte holders, e.g. stack arrays, which we may want to use in some places (like SessionId),
  • it doesn't support human-readable formats

We need to find a good crate that does all that, or finally make our own.

@fjarri fjarri added the code quality Making things simpler label Oct 12, 2024
@fjarri fjarri added this to the v1.0.0 milestone Oct 14, 2024
@fjarri
Copy link
Member Author

fjarri commented Oct 14, 2024

To give some background:

So, as much as I wouldn't want to add another similar-but-not-quite-the-same library to the ecosystem, that seems like the only viable option.

@fjarri
Copy link
Member Author

fjarri commented Oct 16, 2024

To be replaced with http://crates.io/crates/serde-encoded-bytes

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
code quality Making things simpler
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant