Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Android demo doesn't pack multiple architectures from Envoy mobile aar #28

Closed
buildbreaker opened this issue May 13, 2019 · 5 comments
Closed
Labels
platform/android Issues related to Android
Milestone

Comments

@buildbreaker
Copy link

Building the Android demo can only be built with a single architecture.

The current android_binary Bazel rule has a bug (bazelbuild/bazel#8283) where it doesn't pack multiple architectures from aar_imports. Underneath the android_binary, it uses aar_imports for any aar dependencies.

Any Android applications using Bazel depending on Envoy Mobile will have this issue.

@junr03
Copy link
Member

junr03 commented Jun 3, 2019

A fix for this problem will be included in 0.27. per bazelbuild/bazel#8283 (comment). Is this issue blocking for OSS release, or do we currently have an ok solution? If we have a decent solution we can move this issue to envoy-mobile under 0.2 release.

wdyt @buildbreaker?

@buildbreaker
Copy link
Author

We should move to 0.2

@junr03 junr03 transferred this issue from another repository Jun 3, 2019
@junr03 junr03 added demo platform/android Issues related to Android labels Jun 3, 2019
@junr03 junr03 added this to the v0.2 "Primo" milestone Jun 3, 2019
@stale
Copy link

stale bot commented Jul 4, 2019

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or other activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 4, 2019
@junr03
Copy link
Member

junr03 commented Jul 8, 2019

@buildbreaker we fixed this with the fat apk, didn't we? If that is the case do you mind commenting and closing?

@stale stale bot removed the stale label Jul 8, 2019
@buildbreaker
Copy link
Author

@junr03 Correct. This is not really that important since we are able to build a fat aar.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
platform/android Issues related to Android
Projects
None yet
Development

No branches or pull requests

2 participants