Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

No OPUS identifier in audioType (MP4AddAudioTrack) #47

Open
ar-visions opened this issue Nov 30, 2023 · 1 comment
Open

No OPUS identifier in audioType (MP4AddAudioTrack) #47

ar-visions opened this issue Nov 30, 2023 · 1 comment

Comments

@ar-visions
Copy link

ar-visions commented Nov 30, 2023

MP4V2_EXPORT
MP4TrackId MP4AddAudioTrack(
    MP4FileHandle hFile,
    uint32_t      timeScale,
    MP4Duration   sampleDuration,
    uint8_t       audioType DEFAULT(MP4_MPEG4_AUDIO_TYPE) );

there seems to be no audioType for OPUS which is understandable since its so new. My thought is this audioType should be the FourCC identifier and not the uint8_t. Would it be acceptable to allow for this reduction in audio identifiers? When I load a mp4 container the track does not contain this uint8_t so I assume its a binding id to the FourCC?

@ar-visions
Copy link
Author

Just wondering if we can get away with setting MP4_MPEG4_AUDIO_TYPE and using further identification afterwards?

@ar-visions ar-visions changed the title No OPUS identifier in AUDIO TYPE No OPUS identifier in audioType (MP4AddAudioTrack) Nov 30, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant