Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

devOmsCom.cc is not completely device independent #179

Closed
hjunkes opened this issue Sep 24, 2021 · 1 comment
Closed

devOmsCom.cc is not completely device independent #179

hjunkes opened this issue Sep 24, 2021 · 1 comment

Comments

@hjunkes
Copy link

hjunkes commented Sep 24, 2021

In devOmsCom.cc the hard-coded driver table of the oms58 is used.
I don't understand the construct, but shouldn't e.g. when using a MAXv card,
the driver table of that card (MAVv_access) be accessed?

Line 247:
if ((command == PRIMITIVE) && (mr->init != NULL) &&
(strlen(mr->init) != 0))
{
extern struct driver_table oms58_access;
/* Test for a "device directive" in the Initialization string. */
if ((mr->init[0] == '@') && (trans->tabptr == &oms58_access))
{
char *end = strrchr(&mr->init[1], '@');
if (end != NULL)
{

@kmpeters
Copy link
Member

Closing this issue in favor of the new one in motorOms.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants