Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fails to install Ubuntu 18.04 #670

Closed
mangelozzi opened this issue Apr 8, 2020 · 1 comment
Closed

Fails to install Ubuntu 18.04 #670

mangelozzi opened this issue Apr 8, 2020 · 1 comment

Comments

@mangelozzi
Copy link

Followed this guide to install in Ubuntu 18.04.
At the point where one runs make I get the following error:

Scanning dependencies of target msgpackc-static_autogen
[  0%] Automatic MOC for target msgpackc-static
[  0%] Built target msgpackc-static_autogen
Scanning dependencies of target msgpackc-static
[  2%] Building C object third-party/msgpack-c-cpp-1.4.0/CMakeFiles/msgpackc-static.dir/src/unpack.c.o
In file included from /home/michael/builds/neovim-qt/third-party/msgpack-c-cpp-1.4.0/src/unpack.c:268:0:
/home/michael/builds/neovim-qt/third-party/msgpack-c-cpp-1.4.0/include/msgpack/unpack_template.h: In function ‘template_execute’:
/home/michael/builds/neovim-qt/third-party/msgpack-c-cpp-1.4.0/include/msgpack/unpack_template.h:250:17: error: this statement may fall through [-Werror=implicit-fallthrough=]
                 ++p;
                 ^~~
/home/michael/builds/neovim-qt/third-party/msgpack-c-cpp-1.4.0/include/msgpack/unpack_template.h:252:13: note: here
             default:
             ^~~~~~~
cc1: all warnings being treated as errors
third-party/msgpack-c-cpp-1.4.0/CMakeFiles/msgpackc-static.dir/build.make:62: recipe for target 'third-party/msgpack-c-cpp-1.4.0/CMakeFiles/msgpackc-static.dir/src/unpack.c.o' failed
make[2]: *** [third-party/msgpack-c-cpp-1.4.0/CMakeFiles/msgpackc-static.dir/src/unpack.c.o] Error 1
CMakeFiles/Makefile2:141: recipe for target 'third-party/msgpack-c-cpp-1.4.0/CMakeFiles/msgpackc-static.dir/all' failed
make[1]: *** [third-party/msgpack-c-cpp-1.4.0/CMakeFiles/msgpackc-static.dir/all] Error 2
Makefile:162: recipe for target 'all' failed
make: *** [all] Error 2

I think its realted to: #295
I see message pack was increased to 2.1 then reverted back to 1.4. Not sure how to make it install.

@jgehrig
Copy link
Collaborator

jgehrig commented Apr 8, 2020

Where did you download neovim-qt from? You are building an old version.

The latest versions of GCC/Clang enable more aggressive warnings by default. I would recommend upgrading to a more recent version of neovim-qt.

If you do need this specific version, you should link against the system msgpack.

cmake -DCMAKE_BUILD_TYPE=Release -DUSE_SYSTEM_MSGPACK=1 ..

@jgehrig jgehrig closed this as completed Jul 10, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants