You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Since we only need the writing style check when a branch goes into PR review we'd be happy to save some github action runtime contingent by hooking the vale checks only to the pull_request github event (which defaults to opening a PR and synchronize, which is when a new head commit is pushed). That way it would run only on the branches that we need it to run.
I tried and it started (including logging the number of issues found), but the checks were not annotated to code. No errors on the logging output, too so I can't provide details here.
Really just a nice to have but if it works I think it's a better fit to typical workflows.
The text was updated successfully, but these errors were encountered:
Since we only need the writing style check when a branch goes into PR review we'd be happy to save some github action runtime contingent by hooking the vale checks only to the
pull_request
github event (which defaults to opening a PR and synchronize, which is when a new head commit is pushed). That way it would run only on the branches that we need it to run.I tried and it started (including logging the number of issues found), but the checks were not annotated to code. No errors on the logging output, too so I can't provide details here.
Really just a nice to have but if it works I think it's a better fit to typical workflows.
The text was updated successfully, but these errors were encountered: