Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Nice-to-have: Allow hooking to "pull_request" event instead of "push" #10

Closed
nkuehn opened this issue Mar 30, 2020 · 4 comments
Closed
Labels
enhancement New feature or request

Comments

@nkuehn
Copy link

nkuehn commented Mar 30, 2020

Since we only need the writing style check when a branch goes into PR review we'd be happy to save some github action runtime contingent by hooking the vale checks only to the pull_request github event (which defaults to opening a PR and synchronize, which is when a new head commit is pushed). That way it would run only on the branches that we need it to run.

I tried and it started (including logging the number of issues found), but the checks were not annotated to code. No errors on the logging output, too so I can't provide details here.

Really just a nice to have but if it works I think it's a better fit to typical workflows.

@melissamcewen
Copy link

I had the same issue as well. I had to change it to pull to get it to work.

@jdkato jdkato added the enhancement New feature or request label Apr 29, 2020
@jdkato
Copy link
Member

jdkato commented Jun 21, 2020

This should be fixed now.

(You may still run into #12, but you'll get the alerts printed to the console at worst.)

@jdkato jdkato closed this as completed Jun 21, 2020
@nkuehn
Copy link
Author

nkuehn commented Jun 22, 2020

Is there anything to know, e.g. restriction or special config? I can't find a release or documentation.


PS: just found this commit: a62b020#diff-8cfead41d88ad47d44509a8ab0a109adR23-R28 (assuming it's not a release yet)

@jdkato
Copy link
Member

jdkato commented Jun 23, 2020

The release is v1.2.0 (currently on the marketplace).

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants