-
-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
referential links in markdown are linted when they shouldn't be #912
Comments
Can you share the whole file? The issue is not reproducible with that paragraph. |
|
I still can't reproduce it. Is that your complete |
Sorry, gave you the wrong file that's triggering the issue. Here's the correct one. Yes, that's the complete .vale.ini. We're running it through Trunk if that changes anything?
|
This is due to the use of JSX -- since MDX is not an officially supported format, the best you can do in these cases is ignore the block entirely using But this is not a bug with Vale's Markdown processing. #841 is a related issue (although, I don't currently see a good solution there). |
Is there something blocking stripping out the JSX tags like any other HTML tags when preparing the doc for linting? If I take out the tags, this works as expected so it seems like those aren't being removed properly. Alternatively, would a token ignore for |
Vale does not strip any HTML tags; such a strategy would defeat its purpose of being markup-aware (i.e., the expectation that it ignore links). The ignore pattern needs to target the entire JSX block. |
Got it. I think we'll add additional capitalization options in the vocab as a workaround while there's not full MDX support. Thanks for taking a look! |
Check for existing issues
Environment
OS: macOS
install method: Trunk
version: 3.7.1
Describe the bug / provide steps to reproduce it
We have a custom vocab entry for
CLI
which works correctly in most cases. The following line is throwing a linting error for the lowercase version in the link.vale.ini file
The text was updated successfully, but these errors were encountered: