Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

🐈 Task: Bump requests and docker-py versions in ersilia #1146

Open
2 tasks
DhanshreeA opened this issue Jun 4, 2024 · 3 comments · May be fixed by #1150
Open
2 tasks

🐈 Task: Bump requests and docker-py versions in ersilia #1146

DhanshreeA opened this issue Jun 4, 2024 · 3 comments · May be fixed by #1150
Assignees

Comments

@DhanshreeA
Copy link
Member

Summary

From a dependabot alert:

When making requests through a Requests Session, if the first request is made with verify=False to disable cert verification, all subsequent requests to the same origin will continue to ignore cert verification regardless of changes to the value of verify. This behavior will continue for the lifecycle of the connection in the connection pool.
Remediation

Any of these options can be used to remediate the current issue, we highly recommend upgrading as the preferred mitigation.

Upgrade to requests>=2.32.0.
For requests<2.32.0, avoid setting verify=False for the first request to a host while using a Requests Session.
For requests<2.32.0, call close() on Session objects to clear existing connections if verify=False is used.

Related Links

https://github.com/psf/requests/pull/6655

Objective(s)

  • Bump requests to 2.32.0
  • Bump docker_py to 7.1.0

Documentation

psf/requests#6707
psf/requests#6710

@DhanshreeA DhanshreeA self-assigned this Jun 4, 2024
@DhanshreeA DhanshreeA linked a pull request Jun 5, 2024 that will close this issue
@GemmaTuron
Copy link
Member

Hi @DhanshreeA,

There is an open PR regarding this issue. Is it safe to merge it?

@DhanshreeA
Copy link
Member Author

This is presently unsafe to merge, I was facing errors in ersilia tests that I was not able to resolve at the time. I will give another crack at this and close it.

@GemmaTuron
Copy link
Member

Hi @DhanshreeA

What is the plan for that? has this been merged?

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
Status: On Hold
Development

Successfully merging a pull request may close this issue.

2 participants