Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Stable release with PHP 8.4 support #889

Open
mbolli opened this issue Nov 15, 2024 · 9 comments
Open

Stable release with PHP 8.4 support #889

mbolli opened this issue Nov 15, 2024 · 9 comments

Comments

@mbolli
Copy link

mbolli commented Nov 15, 2024

A stable release incorporating #868 would be nice, as PHP 8.4 will get released in the coming weeks.

@ruudk
Copy link

ruudk commented Nov 21, 2024

@erusev Could you please tag a new release? Thanks 🙏 💙

@TomasVotruba
Copy link

That tag would be really helpful 🙏 I'm stuck with only dev dependency in our project for past 2 years

@dregad
Copy link

dregad commented Jan 15, 2025

@erusev Since the 1.8/2.0 release does not seem to be moving forward #897, in the meanwhile it would be truly great if you could apply #868 to the 1.7 branch and tag 1.7.5 release. Thanks in advance !

Edit: actually the patch is already merged in 1.7 (7b307a9), so all we need is a release...

@MyIgel
Copy link

MyIgel commented Jan 26, 2025

@dregad it was included but then reverted in 61a6072 so it must be re-added which therefore breaks PHP < 7.1 compatibility

& to have a "workaround" mentioned: "erusev/parsedown": "dev-master#f7285e7", can be used to force the fix to be used which is just that one merge different than the latest release 1.7.4...f7285e7

@dregad
Copy link

dregad commented Jan 26, 2025

Wow, you're right ! I did not even notice that @xabbuh had reverted his own change in PR #873... Thanks for the heads up !

@erusev Could you please take care of it ?

@dregad
Copy link

dregad commented Jan 26, 2025

Note: If PHP 7.1 compatibility must be guaranteed even though it's been EOL since 2019, I will gladly provide a PR with an alternate solution.

@MyIgel
Copy link

MyIgel commented Jan 26, 2025

I added a potential solution in #899 by explicitly dropping support for PHP < 7.1

@dregad
Copy link

dregad commented Jan 26, 2025

Alternative, backwards-compatible (PHP 5.1+) approach in #900

@MyIgel
Copy link

MyIgel commented Jan 26, 2025

Would be fine for me too as it leads to a fixed release at some point which should be the main focus here

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants