Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix: unsupported-features/node-builtins-modules range compare #252

Merged
merged 1 commit into from
Apr 24, 2024
Merged

fix: unsupported-features/node-builtins-modules range compare #252

merged 1 commit into from
Apr 24, 2024

Conversation

aladdin-add
Copy link

fixes #250

@aladdin-add
fix: unsupported-features/node-builtins-modules range compare
2b43734 
fixes #250

Signed-off-by: 唯然 <weiran.zsd@outlook.com>
@aladdin-add aladdin-add requested a review from scagood April 24, 2024 09:08
@aladdin-add aladdin-add mentioned this pull request Apr 24, 2024
Closed
1 task
scagood
scagood approved these changes Apr 24, 2024
View reviewed changes
Copy link

@scagood scagood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@aladdin-add aladdin-add merged commit d50ae85 into master Apr 24, 2024
19 checks passed
@aladdin-add aladdin-add deleted the issue250 branch April 24, 2024 09:15
@github-actions github-actions bot mentioned this pull request Apr 17, 2024
Merged
@scagood scagood mentioned this pull request Apr 24, 2024
Closed
1 task
aladdin-add added a commit that referenced this pull request Apr 24, 2024
@aladdin-add
Revert "fix: unsupported-features/node-builtins-modules range compare (…
b8332aa 
…#252)"

This reverts commit d50ae85.
@aladdin-add aladdin-add mentioned this pull request Apr 24, 2024
Merged
aladdin-add added a commit that referenced this pull request Apr 24, 2024
@aladdin-add
Revert "fix: unsupported-features/node-builtins-modules range compare" (
caecf3e 
#254)

Revert "fix: unsupported-features/node-builtins-modules range compare (#252)"

This reverts commit d50ae85.
@lholmquist lholmquist mentioned this pull request May 21, 2024
Closed
This was referenced May 29, 2024
Closed
Closed
Closed
@YoutacRandS-VA YoutacRandS-VA mentioned this pull request Jun 20, 2024
Merged
@junsulee junsulee mentioned this pull request Jun 25, 2024
Open
This was referenced Jun 27, 2024
Closed
Closed
@lholmquist lholmquist mentioned this pull request Jul 5, 2024
Closed
This was referenced Aug 2, 2024
Closed
Closed
@lholmquist lholmquist mentioned this pull request Aug 13, 2024
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@scagood scagood scagood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: unsupported-features/node-builtins-modules doesn't work for semver range in v17
2 participants
@aladdin-add @scagood