Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: add strict option to disallow then or catch following await or yield #494

Merged
merged 1 commit into from
Jul 21, 2024

Conversation

brettz9
Copy link
Member

@brettz9 brettz9 commented Jul 21, 2024

feat: add strict option to disallow then or catch following await or yield

Fixes #294

What is the purpose of this pull request?

  • Changes an existing rule

What changes did you make? (Give an overview)

Added a strict option which disallows then or catch following await or yield.

Copy link

codecov bot commented Jul 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (bbcfcbf) to head (fe99945).
Report is 19 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #494   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           25        24    -1     
  Lines          649       661   +12     
  Branches       250       247    -3     
=========================================
+ Hits           649       661   +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brettz9 brettz9 force-pushed the prefer-await-strict branch from 30e47d8 to fe99945 Compare July 21, 2024 09:13
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ota-meshi ota-meshi merged commit fa482cc into eslint-community:main Jul 21, 2024
17 checks passed
Copy link
Contributor

🎉 This PR is included in version 6.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@brettz9 brettz9 deleted the prefer-await-strict branch July 21, 2024 23:54
renovate bot added a commit to mmkal/eslint-plugin-mmkal that referenced this pull request Aug 20, 2024
renovate bot added a commit to mmkal/eslint-plugin-mmkal that referenced this pull request Aug 21, 2024
renovate bot added a commit to mmkal/eslint-plugin-mmkal that referenced this pull request Aug 21, 2024
renovate bot added a commit to mmkal/eslint-plugin-mmkal that referenced this pull request Aug 21, 2024
renovate bot added a commit to mmkal/eslint-plugin-mmkal that referenced this pull request Aug 21, 2024
renovate bot added a commit to mmkal/eslint-plugin-mmkal that referenced this pull request Aug 21, 2024
renovate bot added a commit to mmkal/eslint-plugin-mmkal that referenced this pull request Aug 21, 2024
renovate bot added a commit to mmkal/eslint-plugin-mmkal that referenced this pull request Aug 21, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

prefer-await-to-then doesn't enforce .then/.catch/.finally
2 participants