Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(catch-or-return, prefer-await-to-then): do not report Cypress commands #495

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

brettz9
Copy link
Member

@brettz9 brettz9 commented Jul 22, 2024

Fixes #180

What is the purpose of this pull request?

  • Changes an existing rule

What changes did you make? (Give an overview)

Do not report Cypress commands (e.g., cy.get('sel').then()) for catch-or-return and prefer-await-to-then.

Copy link

codecov bot commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (bbcfcbf) to head (c3fd7f6).
Report is 22 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #495   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           25        24    -1     
  Lines          649       668   +19     
  Branches       250       251    +1     
=========================================
+ Hits           649       668   +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ota-meshi ota-meshi merged commit 943f162 into eslint-community:main Jul 24, 2024
17 checks passed
@brettz9 brettz9 deleted the exclude-cy branch July 24, 2024 11:25
voxpelli pushed a commit that referenced this pull request Aug 6, 2024
🤖 I have created a release *beep* *boop*
---


##
[7.1.0](v7.0.0...v7.1.0)
(2024-08-06)


### 🌟 Features

* **`catch-or-return`, `prefer-await-to-then`:** do not report Cypress
commands
([#495](#495))
([943f162](943f162))
* **`prefer-await-to-then`:** ignore constructor scope unless with
`strict` option
([#496](#496))
([7bffb7a](7bffb7a))
* new rule `spec-only` to check for non-spec Promise methods
([#502](#502))
([d6e9de1](d6e9de1))


### 📚 Documentation

* fixes the CI readme badge
([#511](#511))
([030a3be](030a3be))
* supply missing docs
([#503](#503))
([602d825](602d825))


### 🧹 Chores

* bump dev dependencies
([#483](#483))
([197ae4e](197ae4e))
* **deps-dev:** bump husky from 9.1.1 to 9.1.2
([#516](#516))
([ab8e7a0](ab8e7a0))
* file extension missing
([#519](#519))
([94c9834](94c9834))
* fix format.yml
([#507](#507))
([948c097](948c097))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

avoid 'promise/catch-or-return' errors with Cypress calls
2 participants