Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(no-callback-in-promise): false triggering of callback #574

Merged
merged 3 commits into from
Nov 26, 2024

Conversation

brettz9
Copy link
Member

@brettz9 brettz9 commented Nov 26, 2024

What is the purpose of this pull request?

  • Documentation update
  • Bug fix
  • New rule
  • Changes an existing rule
  • Add autofixing to a rule
  • Other, please explain:

What changes did you make? (Give an overview)

Fixes regression with false triggering by callback

Fixes #572

Co-authored-by: Sebastian Good <2230835+scagood@users.noreply.github.com>
Copy link
Contributor

@scagood scagood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good to me 👍

Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@ota-meshi ota-meshi merged commit 8324564 into eslint-community:main Nov 26, 2024
9 checks passed
renovate bot added a commit to mmkal/eslint-plugin-mmkal that referenced this pull request Nov 27, 2024
@brettz9 brettz9 deleted the no-cb branch December 17, 2024 06:57
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive of no-callback-in-promise in 7.2.0
3 participants