-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix(get-function-name-with-kind): fix default exported function name #26
fix(get-function-name-with-kind): fix default exported function name #26
Conversation
Codecov ReportBase: 96.01% // Head: 96.03% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #26 +/- ##
==========================================
+ Coverage 96.01% 96.03% +0.01%
==========================================
Files 13 13
Lines 653 655 +2
==========================================
+ Hits 627 629 +2
Misses 26 26
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Without the fix, added tests were failing like: 1) The 'getFunctionNameWithKind' function
should return "async generator function 'default'" for "export default async function* () {}".:
AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
+ actual - expected
+ 'async generator function'
- "async generator function 'default'"
+ expected - actual
-async generator function
+async generator function 'default'
at Context.<anonymous> (test/get-function-name-with-kind.js:159:20)
at processImmediate (node:internal/timers:464:21)
2) The 'getFunctionNameWithKind' function
should return "async generator function 'default'" for "export default async function* () {}" if sourceCode is present.:
AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
+ actual - expected
+ 'async generator function'
- "async generator function 'default'"
+ expected - actual
-async generator function
+async generator function 'default'
at Context.<anonymous> (test/get-function-name-with-kind.js:189:20)
at processImmediate (node:internal/timers:464:21)
3) The 'getFunctionNameWithKind' function
should return "async arrow function 'default'" for "export default async () => {}".:
AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
+ actual - expected
+ 'async arrow function'
- "async arrow function 'default'"
+ expected - actual
-async arrow function
+async arrow function 'default'
at Context.<anonymous> (test/get-function-name-with-kind.js:159:20)
at processImmediate (node:internal/timers:464:21)
4) The 'getFunctionNameWithKind' function
should return "async arrow function 'default'" for "export default async () => {}" if sourceCode is present.:
AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
+ actual - expected
+ 'async arrow function'
- "async arrow function 'default'"
+ expected - actual
-async arrow function
+async arrow function 'default' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
🎉 This PR is included in version 4.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Fixes mysticatea#24