Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Augment release-monitor for breaking changes #66

Open
platinumazure opened this issue Mar 22, 2018 · 1 comment
Open

Augment release-monitor for breaking changes #66

platinumazure opened this issue Mar 22, 2018 · 1 comment

Comments

@platinumazure
Copy link
Member

platinumazure commented Mar 22, 2018

I was wondering if it might be worthwhile to augment the release-monitor plugin for breaking changes. Basically, it should create a failing or pending status check for breaking changes unless we know we're about to do a major release.

One possible approach:

  1. Create a "major release pending" label that can be added to Release Issues when we are about to do a major release
  2. Augment release-monitor to check for PRs with "Breaking:" in the merge commit message and create a failing/pending status check, unless there is a "major release" label on the release issue. Status check message would indicate that the change is breaking and that we cannot merge until we are doing a major release.
@not-an-aardvark
Copy link
Member

This sounds reasonable to me, although as far as I know we haven't had a problem with accidentally merging breaking changes in the past. Still, it seems very plausible that someone will make a mistake at some point.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

2 participants