Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Peripheral drivers should validate configuration before applying it to hardware #2839

Open
bugadani opened this issue Dec 19, 2024 · 2 comments
Assignees
Labels
beta-blocker bug Something isn't working
Milestone

Comments

@bugadani
Copy link
Contributor

bugadani commented Dec 19, 2024

apply_config is fallible, which means two things:

  • It can fail
  • The user can ignore the failure and keep using the driver

Because of this, we should validate the whole configuration before we apply it to the hardware. I don't consider this a blocking issue, although we might want to get it right before the release.

@playfulFence
Copy link
Contributor

When this issue is resolved, we must not forget to add the appropriate # Errors entries (see related FIXMEs in this PR).

@playfulFence playfulFence self-assigned this Jan 27, 2025
@MabezDev MabezDev added this to the 1.0.0-beta.0 milestone Jan 27, 2025
@MabezDev
Copy link
Member

On further reflection, and a push from @playfulFence I think this is indeed something we want to get it sooner rather than later, for example we can set the baud to a billion bps, and apply_config will happily try to do it.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
beta-blocker bug Something isn't working
Projects
Status: Todo
Development

No branches or pull requests

4 participants