schedule: fix linked-list (per @dok-net review) (#6147)

d-a-v · web-flow · commit a4ae8564f7ef · 2019-05-27T09:13:38.000+02:00
diff --git a/cores/esp8266/Schedule.cpp b/cores/esp8266/Schedule.cpp
@@ -120,10 +120,12 @@ void run_scheduled_functions()
         {
             if (toCall->mFunc())
             {
+                // function stays in list
                 lastRecurring = toCall;
             }
             else
             {
+                // function removed from list
                 InterruptLock lockAllInterruptsInThisScope;
 
                 if (sFirst == toCall)
@@ -137,6 +139,9 @@ void run_scheduled_functions()
                 recycle_fn_unsafe(toCall);
             }
         }
+        else
+            // function stays in list
+            lastRecurring = toCall;
     }
 
     fence = false;

Original file line number	Diff line number	Diff line change
`@@ -120,10 +120,12 @@ void run_scheduled_functions()`
`120`	`120`	`{`
`121`	`121`	`if (toCall->mFunc())`
`122`	`122`	`{`
	`123`	`+ // function stays in list`
`123`	`124`	`lastRecurring = toCall;`
`124`	`125`	`}`
`125`	`126`	`else`
`126`	`127`	`{`
	`128`	`+ // function removed from list`
`127`	`129`	`InterruptLock lockAllInterruptsInThisScope;`
`128`	`130`
`129`	`131`	`if (sFirst == toCall)`
`@@ -137,6 +139,9 @@ void run_scheduled_functions()`
`137`	`139`	`recycle_fn_unsafe(toCall);`
`138`	`140`	`}`
`139`	`141`	`}`
	`142`	`+ else`
	`143`	`+ // function stays in list`
	`144`	`+ lastRecurring = toCall;`
`140`	`145`	`}`
`141`	`146`
`142`	`147`	`fence = false;`