Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Feature Request: Make MDNS _getServiceTxt(char *name, char *proto) public #4521

Closed
chadham opened this issue Mar 15, 2018 · 6 comments
Closed

Comments

@chadham
Copy link

chadham commented Mar 15, 2018

Need to be able to query serviceTextRecord attributes, method is currently private.

Thanks.

@chadham chadham changed the title Feature Request: Make _getServiceTxt(char *name, char *proto) public Feature Request: Make MDNS _getServiceTxt(char *name, char *proto) public Mar 15, 2018
@devyte
Copy link
Collaborator

devyte commented Mar 16, 2018

Are you aware of pr #3107 ?

@chadham
Copy link
Author

chadham commented Mar 16, 2018 via email

@mblythe86
Copy link
Contributor

I think you misunderstand what _getServiceTxt is doing. That method is used by the responder to send any Txt records you've added with addServiceTxt to others on the network (i.e. when someone else does a query). That's all you'd be able to see from the method...what you've already added.

Without #3107, Txt records on responses to your queries are simply discarded.

@chadham
Copy link
Author

chadham commented Mar 21, 2018

Im looking for a way to get the txt records for a discovered service... (not for txt records I added to the service Im broadcasting)

@mblythe86
Copy link
Contributor

mblythe86 commented Jun 20, 2018

Im looking for a way to get the txt records for a discovered service... (not for txt records I added to the service Im broadcasting)

Ok, then you need #3107. Just making _getServiceTxt public won't get you what you want.

@devyte
Copy link
Collaborator

devyte commented Dec 5, 2018

Closing in view of #5442 with a full rewrite of mdns.

@devyte devyte closed this as completed Dec 5, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants