-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
More for fixing MDNS #8675
Comments
s/LwipIntf::stateUpCB()/LwipIntf::ipChangeCB()/ ? Might be confusing for static ip? Need to check examples, though. Is it 'STATE UP -> set ip addresses' or 'set ip addresses -> STATE UP'? |
We can also considerate bringing interface DOWN then UP when IP changes |
Also seems weird :/ Can we replace |
After @hreintke 's fix (#8641 from #8308), this notice and these lwIP guidelines brought to attention by @mcspr,
our mDNS implementation will benefit from part or all these suggestions:
LwipIntf::stateUpCB()
should trigger also when IP address changeThe text was updated successfully, but these errors were encountered: