Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

ESP8266.beAccessPoint needs a corresponding .stopAccessPoint #638

Closed
rakeshpai opened this issue Oct 9, 2015 · 2 comments
Closed

ESP8266.beAccessPoint needs a corresponding .stopAccessPoint #638

rakeshpai opened this issue Oct 9, 2015 · 2 comments
Labels
enhancement ESP8266 This is only a problem on ESP8266 devices

Comments

@rakeshpai
Copy link

In fact, I'd suggest renaming .beAccessPoint to .startAccessPoint, or even .startAP, and having a corresponding .stopAP.

.stopAP could take a callback as an argument, if the SDK provides a confirmation that the access point has been stopped.
@gfwilliams gfwilliams added the ESP8266 This is only a problem on ESP8266 devices label Oct 9, 2015
@nkolban
Copy link
Contributor

nkolban commented Oct 9, 2015

@rakeshpai Good stuff ... however, see issue #589. We have a work item to address the existence and naming of all WiFi related items. Can I ask you to check out #589 and see if that is perhaps an encompassing issue for this one? If it is, please go ahead and close this issue and add your thoughts to the issue/Wiki page where we are discussing the "correct" design of the exposed interface. Your input is valuable, so if you have time, please come and join.

@rakeshpai
Copy link
Author

I just found the issue and the wiki. I've made a note in the wiki about this. Thanks.

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
enhancement ESP8266 This is only a problem on ESP8266 devices
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rakeshpai @gfwilliams @nkolban